From: Laurent Vivier <laurent@vivier.eu>
To: Ramon Fried <rfried.dev@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
qemu-devel@nongnu.org,
"open list:Xilinx Zynq" <qemu-arm@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on
Date: Wed, 12 Jun 2019 09:40:43 +0200 [thread overview]
Message-ID: <200eff56-ffff-904d-eeef-408b52ce2fa5@vivier.eu> (raw)
In-Reply-To: <CAGi-RUL2QThfiYPeZOE6iuryxT7Daj-y-Q=SSgUBRFcDsWP+zw@mail.gmail.com>
Le 12/06/2019 à 06:27, Ramon Fried a écrit :
>
>
> On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier <laurent@vivier.eu
> <mailto:laurent@vivier.eu>> wrote:
>
> Le 11/06/2019 à 16:55, Ramon Fried a écrit :
> > defining CADENCE_GEM_ERR_DEBUG causes compilation
> > errors, fix that.
> >
> > Signed-off-by: Ramon Fried <rfried.dev@gmail.com
> <mailto:rfried.dev@gmail.com>>
> > ---
> > v2: change %lx to HWADDR_PRIx and %lx to %zdx
>
> HWADDR_PRIx is to use with hwaddr type (packet_desc_addr).
> rx_desc_get_buffer() is uint64_t, you must use PRIx64.
> It may be better to remove also the cast to unsigned.
>
> Other places in the code also use HWADDR_PRIx with rx_desc_get_buffer().
> Should I change them also ?
No, in fact you should change the return type of rx_desc_get_buffer() to
hwaddr.
Thanks,
Laurent
next prev parent reply other threads:[~2019-06-12 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:55 [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on Ramon Fried
2019-06-11 16:21 ` Laurent Vivier
2019-06-12 4:27 ` Ramon Fried
2019-06-12 7:40 ` Laurent Vivier [this message]
2019-06-15 5:10 ` Ramon Fried
2019-06-12 8:59 ` Philippe Mathieu-Daudé
2019-06-12 18:03 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2019-06-12 19:28 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200eff56-ffff-904d-eeef-408b52ce2fa5@vivier.eu \
--to=laurent@vivier.eu \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rfried.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).