Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

[Gleb Natapov <gleb@redhat.com>]

On Thu, Dec 31, 2009 at 12:57:44PM -0600, Anthony Liguori wrote:
> On 12/31/2009 09:33 AM, Gleb Natapov wrote:
> >On Thu, Dec 31, 2009 at 08:15:29AM -0600, Anthony Liguori wrote:
> >>On 12/30/2009 06:16 PM, Gleb Natapov wrote:
> >>>It helps debug problems and it is not intrusive. Since 0.12 will be used
> >>>for a long time I want to add it there for convenience.
> >>
> >>stable is for bug fixes only.
> >>
> >This is to close minded. Not able to debug hard to reproduce problems when they appear
> >at the environment you can't replicate is a bug.
> 
> 
> Every feature is important to someone and there is at least someone
> who wants just about every feature backported to stable.
> 
Agree and that is why practical judgment is needed. Humans, not binary
algorithm decides what to port and what not too.

> Looking at this patch, it adds a new monitor command which
> potentially means that the QMP protocol is changing (as there is now
> a new command).  This is definitely not something we want to do in
> stable.
> 
Does QMP expose list of available command through QMP protocol? Because if
it is not, there is no such issues as you describe at all, but event if it
is isn't the goal of QMP to make handling of such cases transparent for
management software. There will be one more element returned in command
list that is all.

--
			Gleb.