From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQefC-0005RP-UM for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:23:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQef7-0005Ot-AK for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:23:21 -0500 Received: from [199.232.76.173] (port=38348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQef7-0005Op-6d for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:23:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15305) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQef6-0007sL-Rt for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:23:17 -0500 Date: Fri, 1 Jan 2010 12:23:11 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command Message-ID: <20100101102311.GE9233@redhat.com> References: <4B3AB429.5090303@codemonkey.ws> <20091230092728.GB26899@redhat.com> <4B3B60BE.8000302@codemonkey.ws> <20091230142611.GB26626@redhat.com> <20091230143019.GC26626@redhat.com> <4B3BD891.1030102@codemonkey.ws> <20091231001601.GF26626@redhat.com> <4B3CB201.2070102@codemonkey.ws> <20091231153305.GB9233@redhat.com> <4B3CF428.7080806@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3CF428.7080806@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Juan Quintela On Thu, Dec 31, 2009 at 12:57:44PM -0600, Anthony Liguori wrote: > On 12/31/2009 09:33 AM, Gleb Natapov wrote: > >On Thu, Dec 31, 2009 at 08:15:29AM -0600, Anthony Liguori wrote: > >>On 12/30/2009 06:16 PM, Gleb Natapov wrote: > >>>It helps debug problems and it is not intrusive. Since 0.12 will be used > >>>for a long time I want to add it there for convenience. > >> > >>stable is for bug fixes only. > >> > >This is to close minded. Not able to debug hard to reproduce problems when they appear > >at the environment you can't replicate is a bug. > > > Every feature is important to someone and there is at least someone > who wants just about every feature backported to stable. > Agree and that is why practical judgment is needed. Humans, not binary algorithm decides what to port and what not too. > Looking at this patch, it adds a new monitor command which > potentially means that the QMP protocol is changing (as there is now > a new command). This is definitely not something we want to do in > stable. > Does QMP expose list of available command through QMP protocol? Because if it is not, there is no such issues as you describe at all, but event if it is isn't the goal of QMP to make handling of such cases transparent for management software. There will be one more element returned in command list that is all. -- Gleb.