From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQejh-0006Y0-5o for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:28:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQejc-0006XA-L6 for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:28:00 -0500 Received: from [199.232.76.173] (port=59223 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQejc-0006X5-EI for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:27:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12640) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQejc-0008AG-6k for qemu-devel@nongnu.org; Fri, 01 Jan 2010 05:27:56 -0500 Date: Fri, 1 Jan 2010 12:27:52 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command Message-ID: <20100101102752.GF9233@redhat.com> References: <20091230115043.GD26899@redhat.com> <4B3B6BE8.1020404@redhat.com> <20091230155327.GD26626@redhat.com> <4B3B788E.5030602@redhat.com> <4B3BDC95.4040308@codemonkey.ws> <20091231002028.GG26626@redhat.com> <4B3CB316.2020100@codemonkey.ws> <20091231154225.GD9233@redhat.com> <4B3CF5EE.8090602@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3CF5EE.8090602@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lcapitulino@redhat.com, Avi Kivity , qemu-devel@nongnu.org On Thu, Dec 31, 2009 at 01:05:18PM -0600, Anthony Liguori wrote: > On 12/31/2009 09:42 AM, Gleb Natapov wrote: > >On Thu, Dec 31, 2009 at 08:20:06AM -0600, Anthony Liguori wrote: > >>On 12/30/2009 06:20 PM, Gleb Natapov wrote: > >>>I included only the state I need for debugging. I don't what to see > >>>complete state. It will just clatter important info. > >> > >>Someone may find that full state useful though. There's no good > >>reason to not show the entire device's state. > >> > >There is no good reason to not show the entire device's state in > >addition to nicely formated most useful part of it. Here I fixed it for > >you. > > > Have you even attempted to look at what the generic implementation > would be? ioapic has three vmstate fields. If you decode ioredtbl > into six subfields, then you're only adding two addition fields to > be printed. > I you seriously suggesting that we should tie the way device state is migrated to the way device information is printed? > I can't believe that having those two extra fields is really going > to make it any more difficult to debug. > Can't parse that. > And being able to dump any device state is certainly going to be > useful in the future. > No arguing with that. -- Gleb.