From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRsMg-0000ny-RF for qemu-devel@nongnu.org; Mon, 04 Jan 2010 14:13:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRsMb-0000lt-O3 for qemu-devel@nongnu.org; Mon, 04 Jan 2010 14:13:18 -0500 Received: from [199.232.76.173] (port=40400 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRsMb-0000lp-L6 for qemu-devel@nongnu.org; Mon, 04 Jan 2010 14:13:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19650) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRsMb-0004z3-AS for qemu-devel@nongnu.org; Mon, 04 Jan 2010 14:13:13 -0500 Date: Mon, 4 Jan 2010 21:10:08 +0200 From: "Michael S. Tsirkin" Message-ID: <20100104191008.GB20721@redhat.com> References: <20091227113732.GA3833@redhat.com> <20091227203453.GA30873@volta.aurel32.net> <20091227215023.GB3278@redhat.com> <20091227222326.GA10602@hall.aurel32.net> <20091227224021.GA3443@redhat.com> <4B37E752.1020000@codemonkey.ws> <20100104183356.GA18873@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: PCI: Fix bus address conversion (was Re: commit rules for common git tree) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Aurelien Jarno , qemu-devel@nongnu.org On Mon, Jan 04, 2010 at 07:04:38PM +0000, Blue Swirl wrote: > On Mon, Jan 4, 2010 at 6:33 PM, Michael S. Tsirkin wro= te: > >> On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote: > >> > Likewise, if you see a patch go in that you think would have benef= ited > >> > from being on the list, point it out. =A0People are reasonable and= if you > >> > have a good suggestion, they'll value your input and be likely to = seek > >> > it out in the future. > > > > Here is another patch that would have benefitted from review > > before commit: > > > >> commit cf616802171905a9b6d087a69caa3b978b9cd741 > >> Author: Blue Swirl > >> Date: =A0 Sun Dec 27 20:52:36 2009 +0000 > >> > >> =A0 =A0 PCI: Fix bus address conversion > >> > >> =A0 =A0 Pass physical addresses to map functions instead of PCI bus = addresses. > >> > >> =A0 =A0 Signed-off-by: Blue Swirl > > > > and previous related patches. =A0The issues here that I see are: > > > > - IMO mem_base should really be pci_bus_t, as pci address might be > > =A064 bit mapped into 32 bit target > > > > - I think pci to pci bridges need mem_base copied from parent to chil= d, > > =A0this does not seem to be done? > > > > - map functions need to get pci_bus_t (for io), and now they get > > =A0a cpu address there. The real fix IMO is moving the mapping > > =A0to within pci.c. I think Avi had a patch to do this - > > =A0any objections to refreshing it? > > > > Blue Swirl, could you comment please? >=20 > The issues you point out (which may well be valid) are not related to > the change made by the patch and should be addressed by new patches. Yes, there's no harm in fixing them separately. The point I was making is it is better to post patches on list so issues can be pointed out and discussed without the need to dig through git history. > IIRC Avi promised to refresh his patch but never delivered. I think > Paul also wanted that the bus translation would be handled in a more > generic way (eliminate map functions). I'd like to eliminate map functions as well. Do you have a link to the or= iginal patch btw? --=20 MST