From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSFZ5-0004PZ-Us
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:59:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSFZ1-0004Ml-4b
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:59:39 -0500
Received: from [199.232.76.173] (port=47774 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSFZ0-0004Mg-Rh
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:59:35 -0500
Received: from mx20.gnu.org ([199.232.41.8]:36693)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <yamahata@valinux.co.jp>)
	id 1NSFZ0-00073c-Ea
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:59:34 -0500
Received: from mail.valinux.co.jp ([210.128.90.3])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <yamahata@valinux.co.jp>) id 1NS24k-0000X9-F4
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 00:35:26 -0500
Date: Tue, 5 Jan 2010 14:34:55 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Message-ID: <20100105053455.GC24491@valinux.co.jp>
References: <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp>
	<1261642160-22754-23-git-send-email-yamahata@valinux.co.jp>
	<4B4201B2.2070201@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B4201B2.2070201@redhat.com>
Subject: [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci
	hot plug callback.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote:
> On 12/24/09 09:09, Isaku Yamahata wrote:
>> The argument will be used later to remove global variable.
>
>> -static int piix4_device_hotplug(PCIDevice *dev, int state);
>> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state);
>
> You are using that to pass the piix4-pm device state.  How about using  
> "DeviceState*" instead of "void*" then?

Ok. I'll use DeviceState*.

-- 
yamahata