From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSF6I-0008EE-8t
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:29:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSF6D-00087j-K3
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:29:53 -0500
Received: from [199.232.76.173] (port=60374 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSF6D-00087S-BN
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:29:49 -0500
Received: from mx20.gnu.org ([199.232.41.8]:35578)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <amit.shah@redhat.com>)
	id 1NSF6D-0003pP-1X
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:29:49 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1NS87p-0008G0-6j
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 07:03:01 -0500
Date: Tue, 5 Jan 2010 17:31:47 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new
	virtio-serial-bus
Message-ID: <20100105120147.GO29106@amit-x200.redhat.com>
References: <1261597948-24293-1-git-send-email-amit.shah@redhat.com>
	<1261597948-24293-2-git-send-email-amit.shah@redhat.com>
	<1261597948-24293-3-git-send-email-amit.shah@redhat.com>
	<4B32A3D6.2010509@codemonkey.ws>
	<20091224052532.GB25261@amit-x200.redhat.com>
	<4B4253C2.6080508@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B4253C2.6080508@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: agraf@suse.de, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com

On (Mon) Jan 04 2010 [14:46:58], Anthony Liguori wrote:
>
>> I'll annotate and read/write using the le format.
>
> Just use ldl_p and stl_p. (or ldw/stw as appropriate).

OK, I've switched to ldl/stl.

I'll send out the new series once the one I posted yesterday gets some
time on the list.

>>>> +static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
>>>> +{
>>>> +    VirtIOSerialDevice *dev = DO_UPCAST(VirtIOSerialDevice, qdev, qdev);
>>>> +    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,&dev->qdev);
>>>> +
>>>> +    monitor_printf(mon, "%*s dev-prop-int: id: %u\n",
>>>> +                   indent, "", port->id);
>>>> +    monitor_printf(mon, "%*s dev-prop-int: is_console: %d\n",
>>>> +                   indent, "", port->is_console);
>>>> +}
>>>
>>>
>>> This doesn't look used to me.
>>
>> It's helpful for debugging purposes, mostly: 'info qtree' on the monitor
>> will print this out and one can examine port state.
>
> Unused static functions will cause the build to fail with -Werror.

Oh, it's used alright:

static struct BusInfo virtser_bus_info = {
    .name      = "virtio-serial-bus",
    .size      = sizeof(VirtIOSerialBus),
    .print_dev = virtser_bus_dev_print,
};

		Amit