From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSF2E-0004cg-9L
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:25:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSF29-0004Yw-4P
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:25:41 -0500
Received: from [199.232.76.173] (port=33897 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSF28-0004Yn-Ro
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:25:36 -0500
Received: from mx20.gnu.org ([199.232.41.8]:35407)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <amit.shah@redhat.com>)
	id 1NSF28-0002JY-Hq
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:25:36 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1NSAVB-0004BT-Rg
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 09:35:18 -0500
Date: Tue, 5 Jan 2010 20:04:08 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20100105143408.GB19805@amit-x200.redhat.com>
References: <1262626457-26671-1-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-2-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-3-git-send-email-amit.shah@redhat.com>
	<4B4305F7.2040707@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B4305F7.2040707@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/8] virtio-console: qdev conversion, new
	virtio-serial-bus
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

On (Tue) Jan 05 2010 [10:27:19], Gerd Hoffmann wrote:
>   Hi,
>
>> +/* Guest wants to notify us of some event */
>> +static void handle_control_message(VirtIOSerial *vser, void *buf)
>> +{
>
>> +    cpkt->event = le16_to_cpu(cpkt->event);
>> +    cpkt->value = le16_to_cpu(cpkt->value);
>
> Does this modify guest memory?

Hm, I don't want to. I'll use a shadow struct.

>
>> +        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console, 1),
>
> virtser_bus_dev_print() prints this.  Properties are printed by "info  
> qtree" anyway, so you can drop that from virtser_bus_dev_print ...

I had to make is_console a property for other reasons; I'll remove it
from here.

		Amit