From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSCRj-0000UT-Ep for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:39:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSCRe-0000MR-D7 for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:39:50 -0500 Received: from [199.232.76.173] (port=42686 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSCRe-0000Lh-AF for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:39:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4054) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NSCRd-0001Mh-MJ for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:39:45 -0500 Date: Tue, 5 Jan 2010 18:36:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20100105163647.GA29552@redhat.com> References: <1262403933-26881-2-git-send-email-kirill@shutemov.name> <1262403933-26881-3-git-send-email-kirill@shutemov.name> <1262403933-26881-4-git-send-email-kirill@shutemov.name> <1262403933-26881-5-git-send-email-kirill@shutemov.name> <1262403933-26881-6-git-send-email-kirill@shutemov.name> <1262403933-26881-7-git-send-email-kirill@shutemov.name> <1262403933-26881-8-git-send-email-kirill@shutemov.name> <1262403933-26881-9-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 09/15] usb-linux.c: fix warning with _FORTIFY_SOURCE List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: Juan Quintela , qemu-devel@nongnu.org On Tue, Jan 05, 2010 at 06:07:35PM +0200, Kirill A. Shutemov wrote: > On Tue, Jan 5, 2010 at 4:42 PM, Juan Quintela wro= te: > > "Kirill A. Shutemov" wrote: > >> =A0 CC =A0 =A0usb-linux.o > >> cc1: warnings being treated as errors > >> usb-linux.c: In function 'usb_host_read_file': > >> usb-linux.c:1204: error: ignoring return value of 'fgets', declared = with attribute warn_unused_result > >> make: *** [usb-linux.o] Error 1 > >> > >> Signed-off-by: Kirill A. Shutemov > >> --- > >> =A0usb-linux.c | =A0 =A08 ++++++-- > >> =A01 files changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/usb-linux.c b/usb-linux.c > >> index 88728e9..8673474 100644 > >> --- a/usb-linux.c > >> +++ b/usb-linux.c > >> @@ -1201,9 +1201,13 @@ static int usb_host_read_file(char *line, siz= e_t line_size, const char *device_f > >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_file); > >> =A0 =A0 =A0f =3D fopen(filename, "r"); > >> =A0 =A0 =A0if (f) { > >> - =A0 =A0 =A0 =A0fgets(line, line_size, f); > >> + =A0 =A0 =A0 =A0if (fgets(line, line_size, f)) { > >> + =A0 =A0 =A0 =A0 =A0 =A0ret =3D 1; > >> + =A0 =A0 =A0 =A0} else { > >> + =A0 =A0 =A0 =A0 =A0 =A0ret =3D 0; > >> + =A0 =A0 =A0 =A0} > >> + > > This if is equivalent to: > > > > ret =3D !!fgets(line, line_size, f); > > > > No need for the if at all :) >=20 > It's not very readable. > Probably better to use something like: >=20 > ret =3D (fgets(line, line_size, f) !=3D NULL); >=20 Might be matter of taste. E.g. I think !! is more readable than !=3D NULL. And () around !=3D are not needed. It's better to make code brief IMO, a lof of boilerplate hides bugs. Nothing to get hung about though. --=20 MST