From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: [PATCH 1/6] PCI config space access overhaul
Date: Wed, 6 Jan 2010 00:16:37 +0200 [thread overview]
Message-ID: <20100105221637.GF30921@redhat.com> (raw)
In-Reply-To: <1262590375-11431-2-git-send-email-agraf@suse.de>
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote:
> +typedef void (*pci_config_reg_fn)(PCIHostState *s, uint32_t config_reg,
> + PCIConfigAddress *conf);
> +
pci_decode_config_addr_fn would be a better name.
> struct PCIHostState {
> SysBusDevice busdev;
> + pci_config_reg_fn decode_config_reg;
> + PCIConfigAddress config_reg_dec;
decode_config_addr
and
config_addr
would be better names
> uint32_t config_reg;
> PCIBus *bus;
> };
>
> void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len);
> uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len);
> +void pci_host_init(PCIHostState *s);
> +void pci_host_decode_config_reg(PCIHostState *s, uint32_t config_reg,
> + PCIConfigAddress *decoded);
Shouldn't this be static?
And again, pci_host_decode_config_addr would be a better name IMO.
--
MST
next prev parent reply other threads:[~2010-01-05 22:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 7:32 [Qemu-devel] [PATCH 0/6] PPC NewWorld fixery v2 Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 1/6] PCI config space access overhaul Alexander Graf
2010-01-05 12:46 ` Isaku Yamahata
2010-01-05 13:11 ` Michael S. Tsirkin
2010-01-12 10:36 ` Alexander Graf
2010-01-12 10:59 ` Michael S. Tsirkin
2010-01-05 22:16 ` Michael S. Tsirkin [this message]
2010-01-12 10:38 ` [Qemu-devel] " Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 2/6] Add config space conversion function for uni_north Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 3/6] Use Mac99_U3 type on ppc64 Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 4/6] Include dump of lspci -nn on real G5 Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 5/6] Make interrupts work Alexander Graf
2010-01-04 7:32 ` [Qemu-devel] [PATCH 6/6] Enable secondary cmd64x Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105221637.GF30921@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).