From: Gleb Natapov <gleb@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf
Date: Thu, 7 Jan 2010 18:59:42 +0200 [thread overview]
Message-ID: <20100107165941.GA4537@redhat.com> (raw)
In-Reply-To: <4B46118A.9050101@codemonkey.ws>
On Thu, Jan 07, 2010 at 10:53:30AM -0600, Anthony Liguori wrote:
> On 01/07/2010 10:15 AM, Gleb Natapov wrote:
> >>KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always
> >>been present in kvm_para.h. Since we include kvm_para.h
> >>unconditionally, there's no way we wouldn't have
> >>KVM_CPUID_SIGNATURE.
> >>
> >It is there in qemu-kvm and we suppose to bring knowledge from there :)
>
> Hopefully just the good bits.
>
> >But I can drop it if you like.
>
> I don't want to deviate unnecessarily from qemu-kvm so we can
> approach this in one of two ways. We can remove the guard in
> qemu-kvm and Avi can send me a pull request with this feature. I
> can also just pull in the patch as-is and we can fix this in both
> places later. I'm happy either way.
>
Actually qemu-kvm doesn't uses this function right now. It has it's own
version in qemu-kvm-x86.c. The idea was to teach qemu-kvm to use
upstream function instead.
--
Gleb.
next prev parent reply other threads:[~2010-01-07 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 12:44 [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf Gleb Natapov
2010-01-07 16:09 ` Anthony Liguori
2010-01-07 16:15 ` Gleb Natapov
2010-01-07 16:53 ` Anthony Liguori
2010-01-07 16:56 ` Avi Kivity
2010-01-07 17:08 ` Gleb Natapov
2010-01-07 18:02 ` Anthony Liguori
2010-01-07 18:10 ` Gleb Natapov
2010-01-07 16:59 ` Gleb Natapov [this message]
2010-01-07 16:24 ` [Qemu-devel] [PATCHv2] " Gleb Natapov
2010-01-11 19:18 ` Anthony Liguori
2010-01-11 19:33 ` [Qemu-devel] Registering key events android (qemu based) emulator Anwar Ghani
2010-01-11 20:40 ` [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Jan Kiszka
2010-01-11 21:36 ` Anthony Liguori
2010-01-11 23:22 ` Jan Kiszka
2010-01-12 7:23 ` Gleb Natapov
2010-01-12 8:40 ` Avi Kivity
2010-01-12 8:42 ` Avi Kivity
2010-01-13 13:25 ` [Qemu-devel] [PATCHv3] " Gleb Natapov
2010-01-13 16:05 ` Anthony Liguori
2010-01-13 16:14 ` Gleb Natapov
2010-01-13 16:23 ` Gleb Natapov
2010-01-13 16:57 ` Anthony Liguori
2010-01-13 23:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107165941.GA4537@redhat.com \
--to=gleb@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).