From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSviD-00071h-Qp
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:59:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSviA-0006vg-0A
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:59:53 -0500
Received: from [199.232.76.173] (port=59132 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSvi9-0006vI-LO
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:59:49 -0500
Received: from mx20.gnu.org ([199.232.41.8]:16199)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gleb@redhat.com>) id 1NSvi7-0003xz-Ol
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:59:48 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NSvi6-0000vH-EI
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:59:46 -0500
Date: Thu, 7 Jan 2010 18:59:42 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf
Message-ID: <20100107165941.GA4537@redhat.com>
References: <20100107124449.GY4905@redhat.com> <4B46072C.80909@codemonkey.ws>
	<20100107161503.GE4905@redhat.com> <4B46118A.9050101@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B46118A.9050101@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On Thu, Jan 07, 2010 at 10:53:30AM -0600, Anthony Liguori wrote:
> On 01/07/2010 10:15 AM, Gleb Natapov wrote:
> >>KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always
> >>been present in kvm_para.h.  Since we include kvm_para.h
> >>unconditionally, there's no way we wouldn't have
> >>KVM_CPUID_SIGNATURE.
> >>
> >It is there in qemu-kvm and we suppose to bring knowledge from there :)
> 
> Hopefully just the good bits.
> 
> >But I can drop it if you like.
> 
> I don't want to deviate unnecessarily from qemu-kvm so we can
> approach this in one of two ways.  We can remove the guard in
> qemu-kvm and Avi can send me a pull request with this feature.  I
> can also just pull in the patch as-is and we can fix this in both
> places later.  I'm happy either way.
> 
Actually qemu-kvm doesn't uses this function right now. It has it's own
version in qemu-kvm-x86.c. The idea was to teach qemu-kvm to use
upstream function instead.

--
			Gleb.