From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NT6zH-0003um-AV for qemu-devel@nongnu.org; Fri, 08 Jan 2010 00:02:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NT6zC-0003nK-Ce for qemu-devel@nongnu.org; Fri, 08 Jan 2010 00:02:14 -0500 Received: from [199.232.76.173] (port=57146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NT6zC-0003nC-9M for qemu-devel@nongnu.org; Fri, 08 Jan 2010 00:02:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2991) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NT6zB-0003ix-Mx for qemu-devel@nongnu.org; Fri, 08 Jan 2010 00:02:09 -0500 Date: Fri, 8 Jan 2010 10:31:03 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 8/8] Move virtio-serial to Makefile.hw Message-ID: <20100108050103.GA8999@amit-x200.redhat.com> References: <1262849506-27132-1-git-send-email-amit.shah@redhat.com> <1262849506-27132-2-git-send-email-amit.shah@redhat.com> <1262849506-27132-3-git-send-email-amit.shah@redhat.com> <1262849506-27132-4-git-send-email-amit.shah@redhat.com> <1262849506-27132-5-git-send-email-amit.shah@redhat.com> <1262849506-27132-6-git-send-email-amit.shah@redhat.com> <1262849506-27132-7-git-send-email-amit.shah@redhat.com> <1262849506-27132-8-git-send-email-amit.shah@redhat.com> <1262849506-27132-9-git-send-email-amit.shah@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org On (Fri) Jan 08 2010 [01:41:48], Andreas F=E4rber wrote: > > Am 07.01.2010 um 08:31 schrieb Amit Shah: > >> There's nothing target-dependent in the virtio-serial code so allow it >> to be compiled just once for all the targets. >> >> Signed-off-by: Amit Shah >> --- >> Makefile.hw | 2 +- >> Makefile.target | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Makefile.hw b/Makefile.hw >> index bd252f5..b6323fa 100644 >> --- a/Makefile.hw >> +++ b/Makefile.hw >> @@ -13,7 +13,7 @@ QEMU_CFLAGS+=3D-I.. -I$(SRC_PATH)/fpu >> >> obj-y =3D >> obj-y +=3D loader.o >> -obj-y +=3D virtio.o >> +obj-y +=3D virtio.o virtio-serial.o >> obj-y +=3D fw_cfg.o >> obj-y +=3D watchdog.o >> obj-$(CONFIG_ECC) +=3D ecc.o > > Needs to be rebased and applied against Makefile.objs now, s/obj-y/hw-=20 > obj-y/. OK, thanks for the hint. I've rebased my local branch against master. Amit