qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Adam Litke <agl@us.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver
Date: Fri, 8 Jan 2010 15:25:32 -0200	[thread overview]
Message-ID: <20100108152532.43883a6a@doriath> (raw)
In-Reply-To: <1262970091.2767.22.camel@aglitke>

On Fri, 08 Jan 2010 11:01:31 -0600
Adam Litke <agl@us.ibm.com> wrote:

> On Thu, 2010-01-07 at 16:30 -0200, Luiz Capitulino wrote:
> > On Thu, 7 Jan 2010 15:58:30 -0200
> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > 
> > >  I like Daniel's idea too. In practice 'refresh-balloon' is going to
> > > be Anthony's idea #1 for the QMP case, which seems the right way to
> > > do it with QMP.
> > 
> >  Hm, something that has just occurred to me: it's easy to have
> > async messages in the user Monitor, we could add a new type of
> > user print callback called async_print.
> > 
> >  This new callback would be called by the Monitor when the async
> > message API is called but we are in user mode.
> > 
> >  This is really today's user_print, but user data is printed
> > asynchronously.
> 
> There is one thing I am struggling with as I try to implement this
> asynchronous behavior.  How can I suspend the monitor thread to wait for
> the stats update to come through?  I see qemu_cond_timedwait(), but that
> appears to only be used for a VM's cpu threads.  I also see the bottom
> half infrastructure, but I am not sure if that is appropriate either. 

 IIUC, in QMP you won't wait at all and I believe suspend/resume should
work on the user Monitor.

 You can use monitor_ctrl_mode() to know whether you're in QMP or not.

      reply	other threads:[~2010-01-08 17:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 17:08 [Qemu-devel] [RFD] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2010-01-07 15:12 ` [Qemu-devel] " Anthony Liguori
2010-01-07 15:18   ` Avi Kivity
2010-01-07 15:22     ` Anthony Liguori
2010-01-07 15:39       ` Adam Litke
2010-01-08  1:33       ` Jamie Lokier
2010-01-07 15:49   ` Daniel P. Berrange
2010-01-07 16:27     ` Adam Litke
2010-01-07 16:39       ` Avi Kivity
2010-01-07 16:56         ` Anthony Liguori
2010-01-07 17:58           ` Luiz Capitulino
2010-01-07 18:30             ` Luiz Capitulino
2010-01-08 16:31               ` Anthony Liguori
2010-01-08 16:51                 ` Luiz Capitulino
2010-01-08 17:01               ` Adam Litke
2010-01-08 17:25                 ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100108152532.43883a6a@doriath \
    --to=lcapitulino@redhat.com \
    --cc=agl@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).