From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUKb3-0006rK-RO
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 08:46:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUKay-0006pO-KR
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 08:46:17 -0500
Received: from [199.232.76.173] (port=59541 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUKay-0006pF-DF
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 08:46:12 -0500
Received: from verein.lst.de ([213.95.11.210]:41975)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NUKax-0002ao-NT
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 08:46:12 -0500
Date: Mon, 11 Jan 2010 14:46:10 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] dmg: fix ->open failure
Message-ID: <20100111134610.GA27135@lst.de>
References: <20100111130654.GA24241@lst.de> <4B4B2B1F.1090203@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B4B2B1F.1090203@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Mon, Jan 11, 2010 at 02:43:59PM +0100, Kevin Wolf wrote:
> Am 11.01.2010 14:06, schrieb Christoph Hellwig:
> > 
> > Currently the dmg image format driver simply opens the images as raw
> > if any kind of failure happens.  This is contrarty to the behaviour
> > of all other image formats which just return an error and let the
> > block core deal with it.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> 
> I mean looking at the patched code I see lots of things that are wrong,
> but they are all unrelated to your change: There are error cases where
> memory is leaked, and it should use bdrv_* functions instead of the
> native open/read/etc. And obviously coding style is completely off (most
> annoying: tabs!)

Yes, the code pretty much is a mess, but I didn't really want to touch
it.  I just looked into picking up your search host_ for raw patches and
was looking for all the block image driver functionality in the tree.

> 
> Kevin
---end quoted text---