From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUR3z-0000bb-9k
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:40:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUR3u-0000Xy-Hb
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:40:34 -0500
Received: from [199.232.76.173] (port=33536 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUR3u-0000Xu-A2
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:40:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28744)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NUR3t-0000ds-O7
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:40:30 -0500
Date: Mon, 11 Jan 2010 22:37:30 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100111203730.GA20210@redhat.com>
References: <1263241213-19716-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263241213-19716-1-git-send-email-weil@mail.berlios.de>
Subject: [Qemu-devel] Re: [PATCH] pci: Add missing 'const' in argument to
	pci_get_xxx
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Mon, Jan 11, 2010 at 09:20:13PM +0100, Stefan Weil wrote:
> pci_get_byte, pci_get_word, pci_get_long and pci_get_quad
> all take a const uint8_t pointer, because they only read
> the configuration data.
> 
> Their prototypes should reflect this fact.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Applied, thanks!

> ---
>  hw/pci.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index 9b5ae97..025eb9f 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -245,7 +245,7 @@ pci_set_byte(uint8_t *config, uint8_t val)
>  }
>  
>  static inline uint8_t
> -pci_get_byte(uint8_t *config)
> +pci_get_byte(const uint8_t *config)
>  {
>      return *config;
>  }
> @@ -257,9 +257,9 @@ pci_set_word(uint8_t *config, uint16_t val)
>  }
>  
>  static inline uint16_t
> -pci_get_word(uint8_t *config)
> +pci_get_word(const uint8_t *config)
>  {
> -    return le16_to_cpupu((uint16_t *)config);
> +    return le16_to_cpupu((const uint16_t *)config);
>  }
>  
>  static inline void
> @@ -269,9 +269,9 @@ pci_set_long(uint8_t *config, uint32_t val)
>  }
>  
>  static inline uint32_t
> -pci_get_long(uint8_t *config)
> +pci_get_long(const uint8_t *config)
>  {
> -    return le32_to_cpupu((uint32_t *)config);
> +    return le32_to_cpupu((const uint32_t *)config);
>  }
>  
>  static inline void
> @@ -281,9 +281,9 @@ pci_set_quad(uint8_t *config, uint64_t val)
>  }
>  
>  static inline uint64_t
> -pci_get_quad(uint8_t *config)
> +pci_get_quad(const uint8_t *config)
>  {
> -    return le64_to_cpup((uint64_t *)config);
> +    return le64_to_cpup((const uint64_t *)config);
>  }
>  
>  static inline void
> -- 
> 1.6.5