From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUb5u-00019q-FP for qemu-devel@nongnu.org; Tue, 12 Jan 2010 02:23:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUb5o-00016K-Jb for qemu-devel@nongnu.org; Tue, 12 Jan 2010 02:23:13 -0500 Received: from [199.232.76.173] (port=45627 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUb5o-000166-5i for qemu-devel@nongnu.org; Tue, 12 Jan 2010 02:23:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20411) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUb5n-0002LW-N4 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 02:23:08 -0500 Date: Tue, 12 Jan 2010 09:23:02 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Message-ID: <20100112072302.GP7549@redhat.com> References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B4B7988.5090803@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Marcelo Tosatti , Jan Kiszka , qemu-devel@nongnu.org, kvm-devel , Avi Kivity On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: > >diff --git a/target-i386/kvm.c b/target-i386/kvm.c > >index 4084503..6a841de 100644 > >--- a/target-i386/kvm.c > >+++ b/target-i386/kvm.c > >@@ -17,6 +17,7 @@ > > #include > > > > #include > >+#include > > This breaks the build on a default F12 install because while kvm.h > is present, kvm_para.h is not. This is a hard one to fix. > Avi how qemu-kvm compiles there? Or it doesn't? > We can default the kvm search path to /lib/modules/$(uname > -r)/build, we can fix the glibc headers and live with it, or we can > pull in the kvm headers into qemu. > > Avi/Marcelo/Jan, any thoughts from the qemu-kvm side? > > Regards, > > Anthony Liguori -- Gleb.