From: Christoph Hellwig <hch@lst.de>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl
Date: Tue, 12 Jan 2010 11:16:02 +0100 [thread overview]
Message-ID: <20100112101602.GA10900@lst.de> (raw)
In-Reply-To: <1263234619-14522-2-git-send-email-crobinso@redhat.com>
On Mon, Jan 11, 2010 at 01:30:19PM -0500, Cole Robinson wrote:
> Current IDE floppy detection is hardcoded based on source file name.
> Make this smarter by attempting a floppy specific ioctl.
IDE floppys show up as /dev/hd?, these are old legacy floppies.
Otherwise looks good except that I think the ioctl should have a higher
match priority than the name match. Same applies to the CDROM version
of the patch.
next prev parent reply other threads:[~2010-01-12 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:30 [Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl Cole Robinson
2010-01-12 10:16 ` Christoph Hellwig [this message]
2010-01-12 14:35 ` Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112101602.GA10900@lst.de \
--to=hch@lst.de \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).