From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place
Date: Tue, 12 Jan 2010 18:44:38 +0100 [thread overview]
Message-ID: <20100112174438.GA733@lst.de> (raw)
In-Reply-To: <4B4CB47C.7090206@redhat.com>
On Tue, Jan 12, 2010 at 06:42:20PM +0100, Kevin Wolf wrote:
> > @@ -623,6 +623,12 @@ int bdrv_commit(BlockDriverState *bs)
> > if (drv->bdrv_make_empty)
> > return drv->bdrv_make_empty(bs);
> >
> > + /*
> > + * Make sure all data we wrote to the backing device is actually
> > + * stable on disk.
> > + */
> > + if (bs->backing_hd)
> > + bdrv_flush(bs->backing_hd);
> > return 0;
> > }
>
> Format drivers with a bdrv_make_empty return before the flush, so it
> won't work for qcow1. Looks good otherwise.
Oh, okay.
> If it has done a bdrv_make_empty we might also want to flush bs?
Indeed. I'll spin a new version.
next prev parent reply other threads:[~2010-01-12 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 12:49 [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place Christoph Hellwig
2010-01-12 17:42 ` Kevin Wolf
2010-01-12 17:44 ` Christoph Hellwig [this message]
2010-01-12 18:13 ` [Qemu-devel] [PATCH 1/2 v2] " Christoph Hellwig
2010-01-13 9:50 ` Kevin Wolf
2010-01-13 23:26 ` [Qemu-devel] [PATCH 1/2] " Anthony Liguori
2010-01-14 10:21 ` Kevin Wolf
2010-01-17 11:32 ` [Qemu-devel] [PATCH] block: fix cache flushing in bdrv_commit Christoph Hellwig
2010-01-20 14:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112174438.GA733@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).