From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUlrw-0007GM-Uy
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 13:53:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUlrs-00078b-4f
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 13:53:32 -0500
Received: from [199.232.76.173] (port=48150 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUlrr-00078E-Ti
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 13:53:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31613)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NUlrr-0006qA-AN
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 13:53:27 -0500
Date: Tue, 12 Jan 2010 20:50:30 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100112185030.GA3170@redhat.com>
References: <cover.1263124239.git.mst@redhat.com>
	<20100110115253.GD27013@redhat.com> <4B4CABF2.5050204@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B4CABF2.5050204@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv7 3/3] virtio: add features as qdev
	properties
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Jan 12, 2010 at 06:05:54PM +0100, Gerd Hoffmann wrote:
>   Hi,
>
>> +#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
>> +        DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
>> +        DEFINE_PROP_BIT("csum", _state, _field, VIRTIO_NET_F_CSUM, true), \
>> +        DEFINE_PROP_BIT("guest_csum", _state, _field, VIRTIO_NET_F_GUEST_CSUM, true), \
>> +        DEFINE_PROP_BIT("mac", _state, _field, VIRTIO_NET_F_MAC, true), \
>
> Didn't noticed in review, sorry.  This isn't going to work as all  
> network cards already have a 'mac' property to set the mac address.  Try  
> to create a virtio nic with a non-default mac address and watch qemu 
> fail.
>
> cheers,
>   Gerd

Fixed, thanks!