From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUmHh-00068t-O2 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:20:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUmHd-00066A-06 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:20:09 -0500 Received: from [199.232.76.173] (port=35277 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUmHc-000666-QG for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:20:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45808) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUmHc-0006VS-7z for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:20:04 -0500 Date: Tue, 12 Jan 2010 21:16:59 +0200 From: "Michael S. Tsirkin" Message-ID: <20100112191659.GA3258@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori , hch@lst.de, kraxel@redhat.com Without this fix, guest crashes with drive=virtio. Signed-off-by: Michael S. Tsirkin --- Anthony, could you please apply this patch quickly? It's an obvious one and it fixes guest crashes. Also, sorry about missing this in my testing. hw/qdev-properties.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 9e123ae..277ff9e 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -20,7 +20,7 @@ static void bit_prop_set(DeviceState *dev, Property *props, bool val) uint32_t *p = qdev_get_prop_ptr(dev, props); uint32_t mask = qdev_get_prop_mask(props); if (val) - *p |= ~mask; + *p |= mask; else *p &= ~mask; } -- 1.6.6.rc1.43.gf55cc