[Qemu-devel] Re: [RFC 0/7]: Add VNC connect/disconnect events

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon, 11 Jan 2010 13:55:19 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> So perhaps we should declare that the lifecycle is
> 
>   -  CONNECT       (provide IP / port details)
>   -  AUTHENTICATED (provide IP / port details + authenticated ID details
>                     eg x509 dname, or SASL usernsmae)
>   -  DISCONNECT    (provide IP / port details)
> 
> 
> Obviously AUTHENTICATED may be optional if the client goes away
> immedaitely before trying auth. The AUTHENTICATED event probably
> also ought to allow for an indication of success vs failure so 
> the app can see failed login attempts

 I'm having an issue with the reporting of failure.

 Turns out we can have a few error conditions on login and they are
auth mechanism dependent. Also, as I'm not familiar with the code,
it's not always easy to get the ID information on failures.

 So, what is simple to do is to have an event called VNC_AUTHENTICATION,
it will have a 'authenticated' key which can be true or false. If it's true
authentication has been successful and ID information is available,
otherwise authentication has failed and only IP/port info is available.

 Of course that CONNECT and DISCONNECT events are also provided.