From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUmoX-0007os-DJ for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:54:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUmoS-0007lE-Jx for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:54:04 -0500 Received: from [199.232.76.173] (port=59429 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUmoS-0007l5-AK for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:54:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2273) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUmoR-0000k2-Mf for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:53:59 -0500 Date: Tue, 12 Jan 2010 21:50:55 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties Message-ID: <20100112195055.GC3170@redhat.com> References: <20100110115253.GD27013@redhat.com> <20100112180927.GA1510@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100112180927.GA1510@lst.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Rusty Russell , qemu-devel@nongnu.org, kraxel@redhat.com On Tue, Jan 12, 2010 at 07:09:27PM +0100, Christoph Hellwig wrote: > This patch causes 100% reproducible boot panics in a Linux guest using > virtio. > > My qemu command line is: > > /opt/qemu/bin/qemu-system-x86_64 \ > -m 1500 \ > -enable-kvm \ > -drive file=/dev/vg00/qemu-root,if=virtio,media=disk,cache=none,aio=threads \ > -kernel arch/x86/boot/bzImage \ > -append "root=/dev/vda console=tty0 console=ttyS0,38400n8" \ > -nographic > > and the guest dmesg is: So the issue is that wrong block size (0xffffffff) was passed to guest. Would it make sense to add some sanity checking in virtio-blk to make it not crash but fail in probe? Which block size values are sane? -- MST