From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties
Date: Wed, 13 Jan 2010 12:43:05 +0200 [thread overview]
Message-ID: <20100113104305.GA5077@redhat.com> (raw)
In-Reply-To: <20100112220633.GA10029@lst.de>
On Tue, Jan 12, 2010 at 11:06:33PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 09:50:55PM +0200, Michael S. Tsirkin wrote:
> > So the issue is that wrong block size (0xffffffff) was passed
> > to guest. Would it make sense to add some sanity checking in virtio-blk
> > to make it not crash but fail in probe? Which block size values
> > are sane?
>
> Yes, I'll cook up a patch. Basically powers of two up from 512 bytes
> are theoretically sane. In practice I doubt we'll ever see anything
> other than 512 or 4095 bytes.
I also noticed that 0x8000 causes a crash. You can play with other
sizes and see what happens.
--
MST
prev parent reply other threads:[~2010-01-13 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1263124239.git.mst@redhat.com>
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 1/3] qdev: add bit property type Michael S. Tsirkin
2010-01-11 19:50 ` Anthony Liguori
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 2/3] virtio: rename features -> guest_features Michael S. Tsirkin
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties Michael S. Tsirkin
2010-01-12 17:05 ` [Qemu-devel] " Gerd Hoffmann
2010-01-12 18:50 ` Michael S. Tsirkin
2010-01-12 18:09 ` [Qemu-devel] " Christoph Hellwig
2010-01-12 18:52 ` Michael S. Tsirkin
2010-01-12 19:50 ` Michael S. Tsirkin
2010-01-12 22:06 ` Christoph Hellwig
2010-01-13 10:43 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113104305.GA5077@redhat.com \
--to=mst@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).