From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NV2sd-00033N-GP
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:03:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NV2sZ-00031Z-FG
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:03:23 -0500
Received: from [199.232.76.173] (port=55405 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NV2sZ-00031V-71
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:03:19 -0500
Received: from mx20.gnu.org ([199.232.41.8]:63437)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NV2sX-0002IB-Na
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:03:18 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NV2sV-0005I6-3K
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:03:15 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] versatile_pci: user PCIHostState instead
	of PCIBus
Date: Wed, 13 Jan 2010 13:02:50 +0000
References: <1263286378-10398-1-git-send-email-yamahata@valinux.co.jp>
	<1263286378-10398-4-git-send-email-yamahata@valinux.co.jp>
In-Reply-To: <1263286378-10398-4-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201001131302.50565.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, agraf@suse.de, mst@redhat.com

On Tuesday 12 January 2010, Isaku Yamahata wrote:
> To use pci host framework, use PCIHostState instead of PCIBus in
>  PCIVPBState.

No.

pci_host.[ch] provides very specific functionality, it is not a generic PCI 
host device. Specifically it provides indirect access to PCI config space via 
a memory mapped {address,data} pair. The versatile PCI host exposes PCI config 
space directly, so should not be using this code.

If you want a generic framework for PCI hosts then you need to use something 
else. If nothing else, assuming that a PCI host bridge is always is SysBus 
device is wrong.

Paul