From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NV2y2-0005G2-07
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:08:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NV2xx-0005D8-CG
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:08:57 -0500
Received: from [199.232.76.173] (port=45435 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NV2xx-0005Cu-4K
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:08:53 -0500
Received: from mx20.gnu.org ([199.232.41.8]:63712)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NV2xw-000474-Lq
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:08:52 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NV2xv-0005dt-53
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 08:08:51 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Wed, 13 Jan 2010 13:08:27 +0000
References: <1263286378-10398-1-git-send-email-yamahata@valinux.co.jp>
	<1263286378-10398-7-git-send-email-yamahata@valinux.co.jp>
	<20100112101236.GD29926@redhat.com>
In-Reply-To: <20100112101236.GD29926@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201001131308.27756.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 6/6] pci host: make pci_data_{write,
	read}() get PCIConfigAddress.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, agraf@suse.de

> I thought we will get rid of vpb_pci_config_addr, and fill in
> fields in PCIConfigAddress directly.  If we don't, and still
> recode into PC format, this is not making code any prettier
> so I don't really see what this buys us.

I agree. This patch seems to be introducing churn for no benefit.

See also comments about direct v.s. indirect access to PCI config space.
I suspect you're trying to use a common implementation for two fundamentally 
different things.

Paul