qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/6] virtio: net: remove dead assignment
Date: Wed, 13 Jan 2010 22:51:15 +0200	[thread overview]
Message-ID: <20100113205115.GC21445@redhat.com> (raw)
In-Reply-To: <1263380087-31821-3-git-send-email-amit.shah@redhat.com>

On Wed, Jan 13, 2010 at 04:24:43PM +0530, Amit Shah wrote:
> clang-analyzer points out value assigned to 'len' is not used.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/virtio-net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index 02d9180..6e48997 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -532,7 +532,7 @@ static ssize_t virtio_net_receive(VLANClientState *nc, const uint8_t *buf, size_
>          int len, total;
>          struct iovec sg[VIRTQUEUE_MAX_SIZE];
>  
> -        len = total = 0;
> +        total = 0;
>  
>          if ((i != 0 && !n->mergeable_rx_bufs) ||
>              virtqueue_pop(n->rx_vq, &elem) == 0) {
> -- 
> 1.6.2.5
> 
> 

  parent reply	other threads:[~2010-01-13 20:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 10:54 [Qemu-devel] [PATCH 0/6] Remove some dead assignments from clang analyzer report Amit Shah
2010-01-13 10:54 ` [Qemu-devel] [PATCH 1/6] vl.c: Remove dead assignment Amit Shah
2010-01-13 10:54   ` [Qemu-devel] [PATCH 2/6] virtio: net: remove " Amit Shah
2010-01-13 10:54     ` [Qemu-devel] [PATCH 3/6] x86: translate.c: " Amit Shah
2010-01-13 10:54       ` [Qemu-devel] [PATCH 4/6] hw/vga.c: " Amit Shah
2010-01-13 10:54         ` [Qemu-devel] [PATCH 5/6] qcow2-refcount: " Amit Shah
2010-01-13 10:54           ` [Qemu-devel] [PATCH 6/6] json-parser: remove dead increment Amit Shah
2010-01-13 11:46           ` [Qemu-devel] Re: [PATCH 5/6] qcow2-refcount: remove dead assignment Paolo Bonzini
2010-01-13 11:51             ` Amit Shah
2010-01-13 20:51     ` Michael S. Tsirkin [this message]
2010-01-13 23:27   ` [Qemu-devel] [PATCH 1/6] vl.c: Remove " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100113205115.GC21445@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).