* [Qemu-devel] Error message regression @ 2010-01-14 14:50 Aurelien Jarno 2010-01-14 17:11 ` [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Stefan Weil 2010-01-14 17:22 ` [Qemu-devel] Error message regression Andreas Färber 0 siblings, 2 replies; 5+ messages in thread From: Aurelien Jarno @ 2010-01-14 14:50 UTC (permalink / raw) To: Andreas Färber; +Cc: qemu-devel Starting with commit 0e8c9214ba1d4128cf92442cd343bc3733478261, when trying to run make without running configure first, the error message has been changed from: | $ make | Please call configure before running make! | make: *** [config-host.mak] Erreur 1 to this more cryptic message: | $ make | Makefile:78: /Makefile.objs: No such file or directory | make: *** No rule to make target `/Makefile.objs'. Stop. Any idea how to fix that properly? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] Makefile: Fix message for missing configure 2010-01-14 14:50 [Qemu-devel] Error message regression Aurelien Jarno @ 2010-01-14 17:11 ` Stefan Weil 2010-01-14 17:45 ` [Qemu-devel] " Andreas Färber 2010-01-14 19:06 ` [Qemu-devel] " Aurelien Jarno 2010-01-14 17:22 ` [Qemu-devel] Error message regression Andreas Färber 1 sibling, 2 replies; 5+ messages in thread From: Stefan Weil @ 2010-01-14 17:11 UTC (permalink / raw) To: QEMU Developers, afaerber; +Cc: Aurelien Jarno When make is called without a valid configuration, it should tell the user what to do. Revision 0e8c9214ba1d4128cf92442cd343bc3733478261 was a regression which resulted in a message which was no longer user friendly (reported by Aurelien Jarno). This patch restores the old behaviour. Cc: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: Stefan Weil <weil@mail.berlios.de> --- Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index fa7f851..b1bbe6d 100644 --- a/Makefile +++ b/Makefile @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) subdir-%: $(GENERATED_HEADERS) $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) +ifneq ($(wildcard config-host.mak),) include $(SRC_PATH)/Makefile.objs +endif $(common-obj-y): $(GENERATED_HEADERS) $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) -- 1.6.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] Makefile: Fix message for missing configure 2010-01-14 17:11 ` [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Stefan Weil @ 2010-01-14 17:45 ` Andreas Färber 2010-01-14 19:06 ` [Qemu-devel] " Aurelien Jarno 1 sibling, 0 replies; 5+ messages in thread From: Andreas Färber @ 2010-01-14 17:45 UTC (permalink / raw) To: Stefan Weil; +Cc: QEMU Developers, Aurelien Jarno, afaerber Am 14.01.2010 um 18:11 schrieb Stefan Weil: > When make is called without a valid configuration, > it should tell the user what to do. > > Revision 0e8c9214ba1d4128cf92442cd343bc3733478261 > was a regression which resulted in a message > which was no longer user friendly > (reported by Aurelien Jarno). > > This patch restores the old behaviour. > > Cc: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Stefan Weil <weil@mail.berlios.de> Reviewed-by: Andreas Färber <afaerber@opensolaris.org> Looks okay, thanks. Andreas > --- > Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index fa7f851..b1bbe6d 100644 > --- a/Makefile > +++ b/Makefile > @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) > subdir-%: $(GENERATED_HEADERS) > $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" > TARGET_DIR="$*/" all,) > > +ifneq ($(wildcard config-host.mak),) > include $(SRC_PATH)/Makefile.objs > +endif > > $(common-obj-y): $(GENERATED_HEADERS) > $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) > -- > 1.6.5 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Fix message for missing configure 2010-01-14 17:11 ` [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Stefan Weil 2010-01-14 17:45 ` [Qemu-devel] " Andreas Färber @ 2010-01-14 19:06 ` Aurelien Jarno 1 sibling, 0 replies; 5+ messages in thread From: Aurelien Jarno @ 2010-01-14 19:06 UTC (permalink / raw) To: Stefan Weil; +Cc: QEMU Developers, afaerber On Thu, Jan 14, 2010 at 06:11:43PM +0100, Stefan Weil wrote: > When make is called without a valid configuration, > it should tell the user what to do. > > Revision 0e8c9214ba1d4128cf92442cd343bc3733478261 > was a regression which resulted in a message > which was no longer user friendly > (reported by Aurelien Jarno). > > This patch restores the old behaviour. Thanks for the quick reaction, applied. > Cc: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Stefan Weil <weil@mail.berlios.de> > --- > Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index fa7f851..b1bbe6d 100644 > --- a/Makefile > +++ b/Makefile > @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) > subdir-%: $(GENERATED_HEADERS) > $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) > > +ifneq ($(wildcard config-host.mak),) > include $(SRC_PATH)/Makefile.objs > +endif > > $(common-obj-y): $(GENERATED_HEADERS) > $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) > -- > 1.6.5 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Error message regression 2010-01-14 14:50 [Qemu-devel] Error message regression Aurelien Jarno 2010-01-14 17:11 ` [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Stefan Weil @ 2010-01-14 17:22 ` Andreas Färber 1 sibling, 0 replies; 5+ messages in thread From: Andreas Färber @ 2010-01-14 17:22 UTC (permalink / raw) To: Aurelien Jarno; +Cc: QEMU Developers Am 14.01.2010 um 15:50 schrieb Aurelien Jarno: > Starting with commit 0e8c9214ba1d4128cf92442cd343bc3733478261, when > trying to run make without running configure first, the error message > has been changed from: > > | $ make > | Please call configure before running make! > | make: *** [config-host.mak] Erreur 1 > > to this more cryptic message: > > | $ make > | Makefile:78: /Makefile.objs: No such file or directory > | make: *** No rule to make target `/Makefile.objs'. Stop. Sorry, didn't test that. > Any idea how to fix that properly? I'd assume this is due to $SRC_PATH being undefined. Probably an ifneq(...) around the include would do the trick, I'll have a look later today. Andreas ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-14 19:06 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-01-14 14:50 [Qemu-devel] Error message regression Aurelien Jarno 2010-01-14 17:11 ` [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Stefan Weil 2010-01-14 17:45 ` [Qemu-devel] " Andreas Färber 2010-01-14 19:06 ` [Qemu-devel] " Aurelien Jarno 2010-01-14 17:22 ` [Qemu-devel] Error message regression Andreas Färber
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).