From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVRC3-0002C1-0t
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:01:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVRC1-0002A6-Tz
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:01:02 -0500
Received: from [199.232.76.173] (port=34382 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVRC1-00029k-Ot
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:01:01 -0500
Received: from hall.aurel32.net ([88.191.82.174]:45899)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1NVRC1-0006pV-4R
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:01:01 -0500
Date: Thu, 14 Jan 2010 16:00:57 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [patch] alpha-linux-user stat64 issue
Message-ID: <20100114150057.GA16630@volta.aurel32.net>
References: <20091228235833.H44497@stanley.csl.cornell.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20091228235833.H44497@stanley.csl.cornell.edu>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vince Weaver <vince@csl.cornell.edu>
Cc: qemu-devel@nongnu.org

On Tue, Dec 29, 2009 at 12:01:22AM -0500, Vince Weaver wrote:
> Hello
> 
> The stat64/fstat64 syscalls are broken for alpha linux-user.
> 
> This is because Alpha, even though it is native 64-bits, has a stat64 
> syscall that is different than regular stat.  This means that the
> "TARGET_LONG_BITS==64" check in syscall.c isn't enough.  Below is
> a patch that fixes things for me, although it might not be the cleanest 
> fix.
> 
> This issue keeps sixtrack and fma3d spec2k benchmarks from running.

Thanks, applied.

> Vince
> 
> Signed-off-by: Vince Weaver <vince@csl.cornell.edu>
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 1acf1f5..f2dd39e 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -4004,7 +4004,7 @@ static inline abi_long host_to_target_stat64(void *cpu_env,
>      } else
>  #endif
>      {
> -#if TARGET_LONG_BITS == 64
> +#if (TARGET_LONG_BITS == 64) && (!defined(TARGET_ALPHA))
>          struct target_stat *target_st;
>  #else
>          struct target_stat64 *target_st;
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net