From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVUwm-0002oI-Kj
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:01:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVUwh-0002iH-Gh
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:01:31 -0500
Received: from [199.232.76.173] (port=39858 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVUwh-0002i5-8s
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:01:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30549)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NVUwg-00025M-De
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:01:26 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0EJ1Poq009510
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 14 Jan 2010 14:01:25 -0500
Date: Thu, 14 Jan 2010 17:01:14 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100114170114.1daaafae@doriath>
In-Reply-To: <20100114173214.GL23148@redhat.com>
References: <1263487859-6318-1-git-send-email-lcapitulino@redhat.com>
	<20100114173214.GL23148@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v0 0/8]: VNC events and cleanup
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 14 Jan 2010 17:32:14 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Jan 14, 2010 at 02:50:51PM -0200, Luiz Capitulino wrote:
> >  Hi there,
> > 
> >  This series contains two VNC related changes. First a small cleanup
> > is done in the current 'query-vnc' command _response_, then the following
> > QMP events are introduced:
> > 
> > - VNC_CONNECTED: emitted when a VNC client establishes a connection
> > - VNC_INITIALIZED: emitted when the VNC session is made active
> > - VNC_DISCONNECTED: emitted when the conection is closed
> > 
> >  The only issue is the current events documentation. I'm using the
> > current format which is quite bad, things will improve when we have
> > proper documentation support (being worked out by Markus).
> 
> This series looks reasonable to me wrt VNC.
> 
> Should we try to think about what we'll do with other network services ?
> eg will we add SPICE_CONNECTED / SPICE_DISCONNECTED in the future ?
> Similar question for chardevs using networking ?

 That's a good question, you think they should converge some way?

 If the chardev API can tell that a fd belongs to a certain subsystem,
then maybe we could move the machinery of connected/disconnected events
down there.

 But that's only an internal refactoring, at first I think we'll have
to add different events for each subsystem we're interested in.