From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVTYW-00011H-2l for qemu-devel@nongnu.org; Thu, 14 Jan 2010 12:32:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVTYQ-0000uN-Ch for qemu-devel@nongnu.org; Thu, 14 Jan 2010 12:32:22 -0500 Received: from [199.232.76.173] (port=58602 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVTYQ-0000u4-6g for qemu-devel@nongnu.org; Thu, 14 Jan 2010 12:32:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21146) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVTYP-00074k-NM for qemu-devel@nongnu.org; Thu, 14 Jan 2010 12:32:17 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0EHWGGJ023563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jan 2010 12:32:16 -0500 Date: Thu, 14 Jan 2010 17:32:14 +0000 From: "Daniel P. Berrange" Message-ID: <20100114173214.GL23148@redhat.com> References: <1263487859-6318-1-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1263487859-6318-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] Re: [PATCH v0 0/8]: VNC events and cleanup Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, armbru@redhat.com On Thu, Jan 14, 2010 at 02:50:51PM -0200, Luiz Capitulino wrote: > Hi there, > > This series contains two VNC related changes. First a small cleanup > is done in the current 'query-vnc' command _response_, then the following > QMP events are introduced: > > - VNC_CONNECTED: emitted when a VNC client establishes a connection > - VNC_INITIALIZED: emitted when the VNC session is made active > - VNC_DISCONNECTED: emitted when the conection is closed > > The only issue is the current events documentation. I'm using the > current format which is quite bad, things will improve when we have > proper documentation support (being worked out by Markus). This series looks reasonable to me wrt VNC. Should we try to think about what we'll do with other network services ? eg will we add SPICE_CONNECTED / SPICE_DISCONNECTED in the future ? Similar question for chardevs using networking ? Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|