From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVV1y-0008KP-JM for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:06:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVV1x-0008Im-9r for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:06:53 -0500 Received: from [199.232.76.173] (port=47101 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVV1w-0008Ic-SQ for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:06:52 -0500 Received: from hall.aurel32.net ([88.191.82.174]:56327) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NVV1w-000404-Aj for qemu-devel@nongnu.org; Thu, 14 Jan 2010 14:06:52 -0500 Date: Thu, 14 Jan 2010 20:06:48 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix message for missing configure Message-ID: <20100114190648.GI16630@volta.aurel32.net> References: <20100114145026.GA7789@volta.aurel32.net> <1263489103-8419-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1263489103-8419-1-git-send-email-weil@mail.berlios.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers , afaerber@opensolaris.org On Thu, Jan 14, 2010 at 06:11:43PM +0100, Stefan Weil wrote: > When make is called without a valid configuration, > it should tell the user what to do. > > Revision 0e8c9214ba1d4128cf92442cd343bc3733478261 > was a regression which resulted in a message > which was no longer user friendly > (reported by Aurelien Jarno). > > This patch restores the old behaviour. Thanks for the quick reaction, applied. > Cc: Aurelien Jarno > Signed-off-by: Stefan Weil > --- > Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index fa7f851..b1bbe6d 100644 > --- a/Makefile > +++ b/Makefile > @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) > subdir-%: $(GENERATED_HEADERS) > $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) > > +ifneq ($(wildcard config-host.mak),) > include $(SRC_PATH)/Makefile.objs > +endif > > $(common-obj-y): $(GENERATED_HEADERS) > $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) > -- > 1.6.5 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net