[Qemu-devel] [PATCH] Fix a typo in 'P' packet processing for M68K.

[Qemu-devel] [PATCH] Fix a typo in 'P' packet processing for M68K.

[Kazu Hirata]

Hi,

Attached is a patch to fix a typo in 'P' packet processing for M68K.

Without this patch, QEMU fails to honor GDB's P packets from GDB
(writing to registers) for the address registers (A0 - A7).

The problem is because of an obvious typo.  Notice that the second
"if" condition is meant to be n < 16 in:

  if (n < 8) {
    :
  } else if (n < 8) {

Signed-off-by: Kazu Hirata <kazu@codesourcery.com>
---
 gdbstub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 6180171..80477be 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
     if (n < 8) {
         /* D0-D7 */
         env->dregs[n] = tmp;
-    } else if (n < 8) {
+    } else if (n < 16) {
         /* A0-A7 */
         env->aregs[n - 8] = tmp;
     } else {
-- 
1.6.2.4

Re: [Qemu-devel] [PATCH] Fix a typo in 'P' packet processing for M68K.

[Aurelien Jarno]

On Thu, Jan 14, 2010 at 09:08:00AM -0800, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to fix a typo in 'P' packet processing for M68K.
> 
> Without this patch, QEMU fails to honor GDB's P packets from GDB
> (writing to registers) for the address registers (A0 - A7).
> 
> The problem is because of an obvious typo.  Notice that the second
> "if" condition is meant to be n < 16 in:
> 
>   if (n < 8) {
>     :
>   } else if (n < 8) {
> 
> Signed-off-by: Kazu Hirata <kazu@codesourcery.com>

Thanks, applied.

> ---
>  gdbstub.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 6180171..80477be 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
>      if (n < 8) {
>          /* D0-D7 */
>          env->dregs[n] = tmp;
> -    } else if (n < 8) {
> +    } else if (n < 16) {
>          /* A0-A7 */
>          env->aregs[n - 8] = tmp;
>      } else {
> -- 
> 1.6.2.4
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K.

[Aurelien Jarno]

On Wed, Dec 23, 2009 at 04:33:24PM -0800, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to fix a typo in 'P' packet processing for M68K.
> 
> Without this patch, QEMU fails to honor GDB's P packets from GDB
> (writing to registers) for the address registers (A0 - A7).
> 
> The problem is because of an obvious typo.  Notice that the second
> "if" condition is meant to be n < 16 in:
> 
>   if (n < 8) {
>     :
>   } else if (n < 8) {
> 
> I don't have a write access to the repository.  Could someone apply
> this patch if it's OK?

This patch looks ok, but is missing a Signed-of-by:

> Thanks in advance,
> 
> Kazu Hirata
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 055093f..1a1640a 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
>      if (n < 8) {
>          /* D0-D7 */
>          env->dregs[n] = tmp;
> -    } else if (n < 8) {
> +    } else if (n < 16) {
>          /* A0-A7 */
>          env->aregs[n - 8] = tmp;
>      } else {
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K.

[Kazu Hirata]

Hi Aurelien,

>> I don't have a write access to the repository.  Could someone apply
>> this patch if it's OK?
> 
> This patch looks ok, but is missing a Signed-of-by:

Thank you for a review.  I'm going to resubmit the patch in the git style.

Kazu Hirata