From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: gleb@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 1/3] qemu: memory notifiers
Date: Mon, 18 Jan 2010 17:08:43 +0200 [thread overview]
Message-ID: <20100118150843.GG8317@redhat.com> (raw)
In-Reply-To: <4B54759A.1030208@redhat.com>
On Mon, Jan 18, 2010 at 04:52:10PM +0200, Avi Kivity wrote:
> On 01/18/2010 04:44 PM, Michael S. Tsirkin wrote:
>>
>>
>>>> The point is that clients can be registered at any point.
>>>>
>>>> A client that registered when memory is present needs to
>>>> be notified about it.
>>>>
>>>>
>>> It looks very expensive.
>>>
>> Shouldn't be hard to optimize ...
>>
>
> It's O(memory size), which can be very big.
>>> Maybe we mandate clients be registered at init-time?
>>>
>>
>> This might be tricky - vhost currently only registers when the
>> first device is hot-added.
>>
>
> I see.
>
> Maybe coalesce adjacent pages and call the callback with the ranges?
Yes, I'll do that.
next prev parent reply other threads:[~2010-01-18 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1262634464.git.mst@redhat.com>
2010-01-04 19:49 ` [Qemu-devel] [PATCHv2 1/3] qemu: memory notifiers Michael S. Tsirkin
2010-01-18 13:02 ` Avi Kivity
2010-01-18 13:52 ` Michael S. Tsirkin
2010-01-18 13:58 ` Avi Kivity
2010-01-18 14:44 ` Michael S. Tsirkin
2010-01-18 14:52 ` Avi Kivity
2010-01-18 15:08 ` Michael S. Tsirkin [this message]
2010-01-18 15:45 ` Michael S. Tsirkin
2010-01-18 16:04 ` Avi Kivity
2010-01-18 16:08 ` Michael S. Tsirkin
2010-01-18 16:15 ` Avi Kivity
2010-01-04 19:49 ` [Qemu-devel] [PATCHv2 2/3] kvm: move kvm_set_phys_mem around Michael S. Tsirkin
2010-01-04 19:49 ` [Qemu-devel] [PATCHv2 3/3] kvm: move kvm to use memory notifiers Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118150843.GG8317@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).