From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NWtGn-0005ds-Kx
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 10:11:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NWtGi-0005Qy-6D
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 10:11:56 -0500
Received: from [199.232.76.173] (port=42649 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NWtGi-0005Qe-2X
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 10:11:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39961)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NWtGh-0002z4-Mw
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 10:11:51 -0500
Date: Mon, 18 Jan 2010 17:08:43 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2 1/3] qemu: memory notifiers
Message-ID: <20100118150843.GG8317@redhat.com>
References: <cover.1262634464.git.mst@redhat.com>
	<20100104194904.GB21299@redhat.com> <4B545C03.40807@redhat.com>
	<20100118135234.GC8317@redhat.com> <4B54691B.7090601@redhat.com>
	<20100118144456.GD8317@redhat.com> <4B54759A.1030208@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B54759A.1030208@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: gleb@redhat.com, qemu-devel@nongnu.org

On Mon, Jan 18, 2010 at 04:52:10PM +0200, Avi Kivity wrote:
> On 01/18/2010 04:44 PM, Michael S. Tsirkin wrote:
>>
>>    
>>>> The point is that clients can be registered at any point.
>>>>
>>>> A client that registered when memory is present needs to
>>>> be notified about it.
>>>>
>>>>        
>>> It looks very expensive.
>>>      
>> Shouldn't be hard to optimize ...
>>    
>
> It's O(memory size), which can be very big.
>>> Maybe we mandate clients be registered at init-time?
>>>      
>>
>> This might be tricky - vhost currently only registers when the
>> first device is hot-added.
>>    
>
> I see.
>
> Maybe coalesce adjacent pages and call the callback with the ranges?

Yes, I'll do that.