From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXBk3-0006tG-BM
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 05:55:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXBjy-0006rV-Ko
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 05:55:22 -0500
Received: from [199.232.76.173] (port=57704 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXBjy-0006rS-GS
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 05:55:18 -0500
Received: from verein.lst.de ([213.95.11.210]:54719)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NXBjx-00070q-VP
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 05:55:18 -0500
Date: Tue, 19 Jan 2010 11:55:15 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 05/10] block: Return original error codes in
	bdrv_pread/write
Message-ID: <20100119105515.GA12960@lst.de>
References: <1263816696-24122-1-git-send-email-kwolf@redhat.com>
	<1263816696-24122-6-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263816696-24122-6-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 18, 2010 at 01:11:31PM +0100, Kevin Wolf wrote:
> Don't assume -EIO but return the real error.

While I'm not very found of assignment inside of if statements the patch
looks correct,


Reviewed-by: Christoph Hellwig <hch@lst.de>