From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount
Date: Tue, 19 Jan 2010 19:51:28 +0100 [thread overview]
Message-ID: <20100119185128.GA31526@lst.de> (raw)
In-Reply-To: <1263816696-24122-8-git-send-email-kwolf@redhat.com>
On Mon, Jan 18, 2010 at 01:11:33PM +0100, Kevin Wolf wrote:
> If update_refcount fails, try to undo any changes made so far to avoid
> inconsistencies in the image file.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2-refcount.c | 32 +++++++++++++++++++++++++-------
> 1 files changed, 25 insertions(+), 7 deletions(-)
>
> + /*
> + * Try do undo any updates if an error is returned (This may succeed in
> + * some cases like ENOSPC for allocating a new refcount block)
> + */
> + if (ret < 0) {
> + int dummy;
> + dummy = update_refcount(bs, offset, cluster_offset - offset, -addend);
So we recursively call into update_refcount here. What happens an error
causes all updates to fail?
next prev parent reply other threads:[~2010-01-19 18:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 12:11 [Qemu-devel] [PATCH 00/10] qcow2 error path fixes Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table Kevin Wolf
2010-01-19 10:58 ` Christoph Hellwig
2010-01-19 11:25 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate Kevin Wolf
2010-01-19 10:59 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 03/10] qcow2: Return 0/-errno in get_cluster_table Kevin Wolf
2010-01-19 11:06 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset Kevin Wolf
2010-01-19 11:35 ` Christoph Hellwig
2010-01-19 11:57 ` Kevin Wolf
2010-01-19 12:02 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write Kevin Wolf
2010-01-19 10:55 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 06/10] qcow2: Fix error handling in grow_refcount_table Kevin Wolf
2010-01-19 11:36 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount Kevin Wolf
2010-01-19 18:51 ` Christoph Hellwig [this message]
2010-01-20 9:47 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts Kevin Wolf
2010-01-19 18:53 ` Christoph Hellwig
2010-01-20 9:55 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value Kevin Wolf
2010-01-19 18:54 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters " Kevin Wolf
2010-01-19 18:58 ` Christoph Hellwig
2010-01-20 10:02 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119185128.GA31526@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).