From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXJHi-0008Rj-ER
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 13:58:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXJHe-0008Of-56
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 13:58:38 -0500
Received: from [199.232.76.173] (port=43233 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXJHd-0008OR-UN
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 13:58:33 -0500
Received: from verein.lst.de ([213.95.11.210]:38276)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1NXJHd-0004PN-Fw
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 13:58:33 -0500
Date: Tue, 19 Jan 2010 19:58:31 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore
	qcow2_alloc_clusters return value
Message-ID: <20100119185831.GD31526@lst.de>
References: <1263816696-24122-1-git-send-email-kwolf@redhat.com>
	<1263816696-24122-11-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263816696-24122-11-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote:
> @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size)
>  
>      /* write new table (align to cluster) */
>      new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2);
> +    if (new_l1_table_offset < 0) {
> +        return new_l1_table_offset;
> +    }

I think the error return needs to free new_l1_table first.