From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXZfw-0002E0-8X
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 07:28:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXZfr-0002BN-9q
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 07:28:43 -0500
Received: from [199.232.76.173] (port=51425 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXZfq-0002B8-VZ
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 07:28:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60926)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NXZfp-0001S7-4h
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 07:28:38 -0500
Date: Wed, 20 Jan 2010 14:25:32 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW
	related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is
	BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY.
	Need to explicitly request READ-WRITE.
Message-ID: <20100120122532.GB9850@redhat.com>
References: <1263739695-13043-1-git-send-email-nsprei@redhat.com>
	<1263739695-13043-2-git-send-email-nsprei@redhat.com>
	<1263739695-13043-3-git-send-email-nsprei@redhat.com>
	<20100117153202.GC3420@redhat.com>
	<m3d4174s6k.fsf@blackfin.pond.sub.org>
	<20100118104816.GC5874@redhat.com>
	<20100120020543.GG11920@shareable.org>
	<m38wbtb5j3.fsf@blackfin.pond.sub.org>
	<20100120103248.GA22941@redhat.com>
	<m3636x7zba.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3636x7zba.fsf@blackfin.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Naphtali Sprei <nsprei@redhat.com>, qemu-devel@nongnu.org

On Wed, Jan 20, 2010 at 01:09:29PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote:
> >> Jamie Lokier <jamie@shareable.org> writes:
> >> 
> >> > Michael S. Tsirkin wrote:
> >> >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote:
> >> >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT.  We don't have
> >> >> > BDRV_DONT_SNAPSHOT, either.
> >> >> 
> >> >> Well, this just mirros the file access macros: we have RDONLY, WRONLY
> >> >> and RDRW. I assume this similarity is just historical?
> >> >
> >> > To avoid confusion, why don't we just call the flag BDRV_O_WRITABLE.
> >> > Then it's obvious what clearing that flag means.
> >> 
> >> Sounds good to me.
> >
> > Won't it be confused with WRONLY?
> 
> I doubt it.  "Writable" implies "write-only" no more than "readable"
> implies "read-only".

Yes :) But what I am saying is that the disk is readable as well.

-- 
MST