From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXbHt-0006N7-3A
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:12:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXbHo-0006Ib-7s
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:12:00 -0500
Received: from [199.232.76.173] (port=57979 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXbHo-0006IP-20
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:11:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31871)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NXbHn-00045U-IA
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:11:55 -0500
Date: Wed, 20 Jan 2010 16:11:52 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings
	with _FORTIFY_SOURCE
Message-ID: <20100120141152.GK5238@redhat.com>
References: <85e877202ec86dac15d392f5e88d5b5d76e3b02f.1263944807.git.quintela@redhat.com>
	<cc557aab1001192219g423baff2ncf905a33c9a1d56a@mail.gmail.com>
	<20100120103324.GA17856@redhat.com>
	<cc557aab1001200309l738f5aefsdf7da77b25e6e416@mail.gmail.com>
	<4B56ECBC.40804@redhat.com> <m3y6jt6kgb.fsf@blackfin.pond.sub.org>
	<cc557aab1001200436y44fc74d7n4f97d7d46fbefa33@mail.gmail.com>
	<m3ockp53p3.fsf@blackfin.pond.sub.org>
	<20100120130800.GH5238@redhat.com>
	<cc557aab1001200602i7c1d0b86h629c32abe305ee1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cc557aab1001200602i7c1d0b86h629c32abe305ee1@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Kevin Wolf <kwolf@redhat.com>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Wed, Jan 20, 2010 at 04:02:19PM +0200, Kirill A. Shutemov wrote:
> 2010/1/20 Gleb Natapov <gleb@redhat.com>:
> > On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote:
> >> "Kirill A. Shutemov" <kirill@shutemov.name> writes:
> >> > No, compiler can't add anything between. 'char' is always byte-aligned.
> >>
> >> You got some reading to do then.
> >>
> > To be fair this structure is packed, but this is not the reason to write
> > stupid code of course.
> 
> In what way does it stupid? Compiler can't insert pads between two
> arrays of 'char'.
Because this is not wise write tricky code especially if it buys you
nothing. This is not C obfuscation contest and it will bite you later.
What to search where extension[] is initialized? "grep extension" will
not find it! Need to change structure layout? Have to change unrelated
code too, but, of course, can't even know that. So can you please tell
us why that code should stay like it is now?

--
			Gleb.