From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject
Date: Wed, 20 Jan 2010 16:11:14 -0200 [thread overview]
Message-ID: <20100120161114.3bfdebca@doriath> (raw)
In-Reply-To: <m3my08irq3.fsf@blackfin.pond.sub.org>
On Wed, 20 Jan 2010 18:57:56 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
> > Hi,
> >
> > This new version addresses Markus's comments.
> >
> > changelog
> > ---------
> >
> > V1 -> V2
> >
> > - Make class_info's key 'desc' optional
> > - Better indentation
> > - Doc fixes
> >
> > V0 -> V1
> >
> > - Coding style fixes
> > - Make 'BAR' and 'IRQ' keys lowercase
> > - Add 'irq' key to the documentation
> >
> > Thanks.
>
> Looks good, although one comment still applies: PATCH 3/5 regresses info
> pci, 4/5 and 5/5 fix it. Do we care? They're separate because they're
> untested.
There are two problems here, which apply for those whom emulate
the hardware:
1. 'info pci' output will brake with git bisect
2. As the code is untested, it might be broken
Only two 2 seems serious.
Michael, does the sparc image on qemu.org have the hardware
in question (pci bridge)?
next prev parent reply other threads:[~2010-01-20 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 16:39 [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject Luiz Capitulino
2010-01-20 16:39 ` [Qemu-devel] [PATCH 1/5] QList: Introduce QLIST_FOREACH_ENTRY() Luiz Capitulino
2010-01-20 16:39 ` [Qemu-devel] [PATCH 2/5] QDict: Introduce qdict_get_qdict() Luiz Capitulino
2010-01-20 16:39 ` [Qemu-devel] [PATCH 3/5] PCI: Convert pci_info() to QObject Luiz Capitulino
2010-01-20 16:39 ` [Qemu-devel] [PATCH 4/5] PCI: do_pci_info(): PCI bridge support Luiz Capitulino
2010-01-20 16:39 ` [Qemu-devel] [PATCH 5/5] PCI: do_pci_info(): PCI bridge devices support Luiz Capitulino
2010-01-20 17:57 ` [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject Markus Armbruster
2010-01-20 18:11 ` Luiz Capitulino [this message]
2010-01-20 19:22 ` Blue Swirl
2010-01-21 13:52 ` Luiz Capitulino
2010-01-21 17:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120161114.3bfdebca@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).