From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXf1d-0005R2-W5
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 13:11:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXf1Z-0005PF-OU
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 13:11:29 -0500
Received: from [199.232.76.173] (port=60876 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXf1Y-0005P4-Mr
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 13:11:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57493)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NXf1X-0001pk-Ib
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 13:11:24 -0500
Date: Wed, 20 Jan 2010 16:11:14 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject
Message-ID: <20100120161114.3bfdebca@doriath>
In-Reply-To: <m3my08irq3.fsf@blackfin.pond.sub.org>
References: <1264005551-12989-1-git-send-email-lcapitulino@redhat.com>
	<m3my08irq3.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com

On Wed, 20 Jan 2010 18:57:56 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> >  Hi,
> >
> >  This new version addresses Markus's comments.
> >
> > changelog
> > ---------
> >
> > V1 -> V2
> >
> > - Make class_info's key 'desc' optional
> > - Better indentation
> > - Doc fixes
> >
> > V0 -> V1
> >
> > - Coding style fixes
> > - Make 'BAR' and 'IRQ' keys lowercase
> > - Add 'irq' key to the documentation
> >
> >  Thanks.
> 
> Looks good, although one comment still applies: PATCH 3/5 regresses info
> pci, 4/5 and 5/5 fix it.  Do we care?  They're separate because they're
> untested.

 There are two problems here, which apply for those whom emulate
the hardware:

1. 'info pci' output will brake with git bisect

2. As the code is untested, it might be broken

 Only two 2 seems serious.

 Michael, does the sparc image on qemu.org have the hardware
in question (pci bridge)?