* [Qemu-devel] [PATCH] fix savevm command without id or tag
@ 2010-01-20 16:26 Marcelo Tosatti
2010-01-20 16:45 ` Kevin Wolf
2010-01-26 21:59 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2010-01-20 16:26 UTC (permalink / raw)
To: qemu-devel
savevm without id or tag segfaults in:
(gdb) bt
#0 0x00007f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6
#1 0x00000000004745b6 in bdrv_snapshot_find (bs=<value optimized out>,
sn_info=0x7fff996be280, name=0x0) at savevm.c:1631
#2 0x0000000000475c80 in del_existing_snapshots (name=<value optimized out>,
mon=<value optimized out>) at savevm.c:1654
#3 do_savevm (name=<value optimized out>, mon=<value optimized out>)
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/savevm.c b/savevm.c
index b3bb909..2fd3de6 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1718,7 +1718,7 @@ void do_savevm(Monitor *mon, const QDict *qdict)
sn->vm_clock_nsec = qemu_get_clock(vm_clock);
/* Delete old snapshots of the same name */
- if (del_existing_snapshots(mon, name) < 0) {
+ if (name && del_existing_snapshots(mon, name) < 0) {
goto the_end;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] fix savevm command without id or tag
2010-01-20 16:26 [Qemu-devel] [PATCH] fix savevm command without id or tag Marcelo Tosatti
@ 2010-01-20 16:45 ` Kevin Wolf
2010-01-26 21:59 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2010-01-20 16:45 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: qemu-devel
Am 20.01.2010 17:26, schrieb Marcelo Tosatti:
>
> savevm without id or tag segfaults in:
>
> (gdb) bt
> #0 0x00007f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6
> #1 0x00000000004745b6 in bdrv_snapshot_find (bs=<value optimized out>,
> sn_info=0x7fff996be280, name=0x0) at savevm.c:1631
> #2 0x0000000000475c80 in del_existing_snapshots (name=<value optimized out>,
> mon=<value optimized out>) at savevm.c:1654
> #3 do_savevm (name=<value optimized out>, mon=<value optimized out>)
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
>
>
> diff --git a/savevm.c b/savevm.c
> index b3bb909..2fd3de6 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1718,7 +1718,7 @@ void do_savevm(Monitor *mon, const QDict *qdict)
> sn->vm_clock_nsec = qemu_get_clock(vm_clock);
>
> /* Delete old snapshots of the same name */
> - if (del_existing_snapshots(mon, name) < 0) {
> + if (name && del_existing_snapshots(mon, name) < 0) {
> goto the_end;
> }
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] fix savevm command without id or tag
2010-01-20 16:26 [Qemu-devel] [PATCH] fix savevm command without id or tag Marcelo Tosatti
2010-01-20 16:45 ` Kevin Wolf
@ 2010-01-26 21:59 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-01-26 21:59 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: qemu-devel
Applied. Thanks.
Regards,
Anthony Liguori
On 01/20/2010 10:26 AM, Marcelo Tosatti wrote:
> savevm without id or tag segfaults in:
>
> (gdb) bt
> #0 0x00007f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6
> #1 0x00000000004745b6 in bdrv_snapshot_find (bs=<value optimized out>,
> sn_info=0x7fff996be280, name=0x0) at savevm.c:1631
> #2 0x0000000000475c80 in del_existing_snapshots (name=<value optimized out>,
> mon=<value optimized out>) at savevm.c:1654
> #3 do_savevm (name=<value optimized out>, mon=<value optimized out>)
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
>
> diff --git a/savevm.c b/savevm.c
> index b3bb909..2fd3de6 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1718,7 +1718,7 @@ void do_savevm(Monitor *mon, const QDict *qdict)
> sn->vm_clock_nsec = qemu_get_clock(vm_clock);
>
> /* Delete old snapshots of the same name */
> - if (del_existing_snapshots(mon, name)< 0) {
> + if (name&& del_existing_snapshots(mon, name)< 0) {
> goto the_end;
> }
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-26 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 16:26 [Qemu-devel] [PATCH] fix savevm command without id or tag Marcelo Tosatti
2010-01-20 16:45 ` Kevin Wolf
2010-01-26 21:59 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).