From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXdlu-000699-3l
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 11:51:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXdlp-000623-4l
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 11:51:09 -0500
Received: from [199.232.76.173] (port=57819 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXdlo-00061h-Mu
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 11:51:04 -0500
Received: from pig.zood.org ([194.242.112.24]:35241)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lool@dooz.org>) id 1NXdlo-0004T8-8A
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 11:51:04 -0500
Date: Wed, 20 Jan 2010 17:51:03 +0100
From: =?iso-8859-1?Q?Lo=EFc?= Minier <lool@dooz.org>
Subject: Re: [Qemu-devel] Re: Stop using "which" in ./configure
Message-ID: <20100120165103.GA3303@pig.zood.org>
References: <yw1xtyukyiny.fsf@unicorn.mansr.com>
	<4B531406.2070904@mail.berlios.de>
	<yw1xwrzgx0bb.fsf@unicorn.mansr.com>
	<20100119101119.GA11358@bee.dooz.org>
	<20100119114750.GB11613@bee.dooz.org>
	<yw1xy6juotjq.fsf@unicorn.mansr.com>
	<20100120113741.GA31679@pig.zood.org> <hj6sbl$hgb$1@ger.gmane.org>
	<20100120134940.GA547@pig.zood.org> <hj73cd$aie$1@ger.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <hj73cd$aie$1@ger.gmane.org>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Jan 20, 2010, Paolo Bonzini wrote:
> >  Are you saying that I can't backup/restore IFS without setting it
> >  first?
> Yes, it affects the behavior of read for example:
> $ echo a b c | (read a b c; echo $a; echo $b; echo $c)
> a
> b
> c
> $ IFS=3D
> $ echo a b c | (read a b c; echo $a; echo $b; echo $c)
> a b c
>=20
> $
> (It's not used by QEMU's configure, but it's better to be defensive).

 I *do* understand that changing IFS will affect the program, but the
 patch I sent will backup IFS and then restore it; perhaps you missed
 the backup/restore bits:

 +    local_ifs=3D"$IFS"
 [...]
 +    IFS=3D:
 [...]
 +            IFS=3D"$local_ifs"
 +            return 0
 [...]
 +    IFS=3D"$local_ifs"
 +    return 1

 Do you have an example of how that breaks if IFS isn't ever set in
 ./configure at all?

--=20
Lo=EFc Minier