From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXrbn-0003FG-F5
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 02:37:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXrbg-0003ES-Tj
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 02:37:37 -0500
Received: from [199.232.76.173] (port=40933 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXrbg-0003EP-QY
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 02:37:32 -0500
Received: from mx20.gnu.org ([199.232.41.8]:43641)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gleb@redhat.com>) id 1NXrbg-0005f5-Ac
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 02:37:32 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NXrbf-0001yS-IG
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 02:37:31 -0500
Date: Thu, 21 Jan 2010 09:37:27 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with
	_FORTIFY_SOURCE
Message-ID: <20100121073727.GQ5238@redhat.com>
References: <cover.1264017981.git.quintela@redhat.com>
	<086f8b2c736cb88cf217fe10ab558eec92fc000d.1264017981.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <086f8b2c736cb88cf217fe10ab558eec92fc000d.1264017981.git.quintela@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, qemu-devel@nongnu.org

On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote:
> From: Kirill A. Shutemov <kirill@shutemov.name>
> 
> CC    block/vvfat.o
> cc1: warnings being treated as errors
> block/vvfat.c: In function 'commit_one_file':
> block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result
> make: *** [block/vvfat.o] Error 1
>   CC    block/vvfat.o
> In file included from /usr/include/stdio.h:912,
>                  from ./qemu-common.h:19,
>                  from block/vvfat.c:27:
> In function 'snprintf',
>     inlined from 'init_directories' at block/vvfat.c:871,
>     inlined from 'vvfat_open' at block/vvfat.c:1068:
> /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer
> make: *** [block/vvfat.o] Error 1
> 
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  block/vvfat.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 063f731..df957e5 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
>      {
>  	direntry_t* entry=array_get_next(&(s->directory));
>  	entry->attributes=0x28; /* archive | volume label */
> -	snprintf((char*)entry->name,11,"QEMU VVFAT");
> +	memcpy(entry->name,"QEMU VVF",8);
> +	memcpy(entry->extension,"AT ",3);
>      }
> 
Before the change extension was initialized to "AT\0" after it is "AT "

>      /* Now build FAT, and write back information into directory */
> @@ -2256,7 +2257,11 @@ static int commit_one_file(BDRVVVFATState* s,
>  	c = c1;
>      }
> 
> -    ftruncate(fd, size);
> +    if (ftruncate(fd, size)) {
> +        perror("ftruncate()");
> +        close(fd);
> +        return -4;
> +    }
>      close(fd);
> 
>      return commit_mappings(s, first_cluster, dir_index);
> -- 
> 1.6.6
> 
> 

--
			Gleb.