From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXx4X-0003ED-Ha for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:27:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXx4T-0003Ba-Mn for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:27:41 -0500 Received: from [199.232.76.173] (port=33461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXx4T-0003BI-7o for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:27:37 -0500 Received: from mx20.gnu.org ([199.232.41.8]:65125) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXx4S-00020O-QS for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:27:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXx43-0003FZ-F4 for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:27:11 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0LDR4Tx009741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 21 Jan 2010 08:27:04 -0500 Date: Thu, 21 Jan 2010 11:26:56 -0200 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH v2 6/8] monitor: New argument type 'T' Message-ID: <20100121112656.7d702af9@doriath> In-Reply-To: <1264003702-17329-7-git-send-email-armbru@redhat.com> References: <1264003702-17329-1-git-send-email-armbru@redhat.com> <1264003702-17329-7-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Wed, 20 Jan 2010 17:08:20 +0100 Markus Armbruster wrote: > This is a double value with optional suffixes ms, us, ns. We'll need > this to get migrate_set_downtime() QMP-ready. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 16 +++++++++++++++- > 1 files changed, 15 insertions(+), 1 deletions(-) > > diff --git a/monitor.c b/monitor.c > index ce97e7b..6dafe0b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -75,6 +75,9 @@ > * user mode accepts an optional G, g, M, m, K, k suffix, > * which multiplies the value by 2^30 for suffixes G and > * g, 2^20 for M and m, 2^10 for K and k > + * 'T' double > + * user mode accepts an optional ms, us, ns suffix, > + * which divides the value by 1e3, 1e6, 1e9, respectively > * '/' optional gdb-like print format (like "/10x") > * > * '?' optional type (for all types, except '/') > @@ -3544,6 +3547,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, > } > break; > case 'b': > + case 'T': > { > double val; > > @@ -3558,7 +3562,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, > if (get_double(mon, &val, &p) < 0) { > goto fail; > } > - if (*p) { > + if (c == 'b' && *p) { > switch (*p) { > case 'K': case 'k': > val *= 1 << 10; p++; break; > @@ -3568,6 +3572,16 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, > val *= 1 << 30; p++; break; > } > } > + if (c == 'T' && p[0] && p[1] == 's') { Is this indexing of 'p' really correct? What if the value you're interested is at the of the string? Like: .args_type = "str:s,value:b" > + switch (*p) { > + case 'm': > + val /= 1e3; p += 2; break; > + case 'u': > + val /= 1e6; p += 2; break; > + case 'n': > + val /= 1e9; p += 2; break; > + } > + } > if (*p && !qemu_isspace(*p)) { > monitor_printf(mon, "Unknown unit suffix\n"); > goto fail;