From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXxSu-00046N-EI
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:52:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXxSq-00042P-Qo
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:52:52 -0500
Received: from [199.232.76.173] (port=59514 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXxSq-00042G-Mp
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:52:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52567)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NXxSq-00081s-5m
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 08:52:48 -0500
Date: Thu, 21 Jan 2010 11:52:39 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject
Message-ID: <20100121115239.0a8ea7ab@doriath>
In-Reply-To: <f43fc5581001201122w7e16bf48m221949909d658711@mail.gmail.com>
References: <1264005551-12989-1-git-send-email-lcapitulino@redhat.com>
	<m3my08irq3.fsf@blackfin.pond.sub.org>
	<20100120161114.3bfdebca@doriath>
	<f43fc5581001201122w7e16bf48m221949909d658711@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Wed, 20 Jan 2010 19:22:48 +0000
Blue Swirl <blauwirbel@gmail.com> wrote:

> On Wed, Jan 20, 2010 at 6:11 PM, Luiz Capitulino <lcapitulino@redhat.com>=
 wrote:
> > On Wed, 20 Jan 2010 18:57:56 +0100
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Luiz Capitulino <lcapitulino@redhat.com> writes:
> >>
> >> > =C2=A0Hi,
> >> >
> >> > =C2=A0This new version addresses Markus's comments.
> >> >
> >> > changelog
> >> > ---------
> >> >
> >> > V1 -> V2
> >> >
> >> > - Make class_info's key 'desc' optional
> >> > - Better indentation
> >> > - Doc fixes
> >> >
> >> > V0 -> V1
> >> >
> >> > - Coding style fixes
> >> > - Make 'BAR' and 'IRQ' keys lowercase
> >> > - Add 'irq' key to the documentation
> >> >
> >> > =C2=A0Thanks.
> >>
> >> Looks good, although one comment still applies: PATCH 3/5 regresses in=
fo
> >> pci, 4/5 and 5/5 fix it. =C2=A0Do we care? =C2=A0They're separate beca=
use they're
> >> untested.
> >
> > =C2=A0There are two problems here, which apply for those whom emulate
> > the hardware:
> >
> > 1. 'info pci' output will brake with git bisect
> >
> > 2. As the code is untested, it might be broken
> >
> > =C2=A0Only two 2 seems serious.
> >
> > =C2=A0Michael, does the sparc image on qemu.org have the hardware
> > in question (pci bridge)?
>=20
> Sparc64 has two Simba bridges, but currently they are broken so there
> are no devices behind them. In addition there should be a DEC 21154
> bridge.

 Can the DEC one have devices attached to it?

> There is no Sparc64 test image yet (very few Sparc32 machines did have
> any PCI and we don't emulate them), but you can test the output
> without any images:

 Oh man, thanks a lot!

 I got an abort() :)