From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZ7Iv-0004Yl-CM for qemu-devel@nongnu.org; Sun, 24 Jan 2010 13:35:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZ7Ir-0004Vd-Sn for qemu-devel@nongnu.org; Sun, 24 Jan 2010 13:35:21 -0500 Received: from [199.232.76.173] (port=41117 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZ7Ir-0004VQ-HN for qemu-devel@nongnu.org; Sun, 24 Jan 2010 13:35:17 -0500 Received: from mail2.shareable.org ([80.68.89.115]:41650) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZ7Ir-0002hg-2g for qemu-devel@nongnu.org; Sun, 24 Jan 2010 13:35:17 -0500 Date: Sun, 24 Jan 2010 18:35:14 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support Message-ID: <20100124183514.GA14840@shareable.org> References: <1264108180-3666-1-git-send-email-lcapitulino@redhat.com> <1264108180-3666-9-git-send-email-lcapitulino@redhat.com> <4B59E8DF.5020001@codemonkey.ws> <4B5C2251.7050509@redhat.com> <20100124110725.GA5668@shareable.org> <4B5C68D6.6090502@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B5C68D6.6090502@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino , Avi Kivity , armbru@redhat.com Anthony Liguori wrote: > >I'd like to be able to connect and be sure not to receive any async > >messages, from simple scripts with simple output parsing. > > You can't have simple output parsing with QMP. You need a full JSON > stack. The simplest script would be a python script that uses the > builtin json support. Having async messages means that you'll have to > loop on recv in order make sure that the response is a command response > vs. an async message. It's just a few lines more of code so I have a > hard time believing it's really a problem. > > But what you probably want is a python QMP library and that would mean > you wouldn't need the few more lines of code. You're right. To be honest, parsing JSON can be done in a single Perl regexp; a "full JSON stack" isn't much. On that note, it'd be good if the end of a QMP message is framed with something that can't appear inside the JSON value, without having to parse the JSON incrementally on each partial read(). There are plenty of short character sequences to choose from that can't appear. Some JSON parsers expect a whole well-formed expression or throw a parse error - it's what people do over HTTP after all. So you wait until you think you've read a whole one, then pass it to the JSON parser. > >If async messages can only be received as a result of commands which > >trigger individual messages, that will be achieved. > > > >But it would be a nice little bonus if disabling async messages caused > >all slow commands to be synchronous - that is, the async result > >message becomes the command's synchronous result. > > I know what you're getting at but I think it's the wrong target for > QMP. The goal is not to allow simple, hacky clients, but to provide a > robust management API. It should not be difficult to use, but parsing > it in a shell with awk is not a requirement in my mind :-) I agree - not a requirement. Just seemed nice if that turned out to be a natural thing to do anyway. -- Jamie