From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZ9vu-00088C-Rv
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 16:23:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZ9vq-00086C-28
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 16:23:46 -0500
Received: from [199.232.76.173] (port=57324 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZ9vp-000867-UQ
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 16:23:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50326)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NZ9vp-0003BO-S4
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 16:23:42 -0500
Date: Sun, 24 Jan 2010 23:20:34 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100124212034.GA6415@redhat.com>
References: <20100124163452.GB8270@gondor.middle-earth.priv>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100124163452.GB8270@gondor.middle-earth.priv>
Subject: [Qemu-devel] Re: [PATCH,
	RESEND] usb: increase buffer for USB control requests
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Krause <chkr@plauener.de>
Cc: qemu-devel@nongnu.org

On Sun, Jan 24, 2010 at 05:34:52PM +0100, Christian Krause wrote:
> Resend. The patch was already sent to the list on 2009-12-11. It would
> be great if it could be reviewed and applied. Thank you very much
> in advance.
> 
> The WLAN USB stick ZyXEL NWD271N (0586:3417) uses very large
> usb control transfers of more than 2048 bytes which won't fit
> into the buffer of the ctrl_struct. This results in an error message
> "husb: ctrl buffer too small" and a non-working device.
> Increasing the buffer size to 8192 seems to be a safe choice.
> 
> Signed-off-by: Christian Krause <chkr@plauener.de>

Are there any drawbacks to make\ing the buffer larger?
If no, let's just make it 64K? IIUC that's a maximum
length for control transfers as length is a 16 bit field.


> ---
>  usb-linux.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/usb-linux.c b/usb-linux.c
> index 285ac22..d205bd3 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -113,7 +113,7 @@ struct ctrl_struct {
>      uint16_t offset;
>      uint8_t  state;
>      struct   usb_ctrlrequest req;
> -    uint8_t  buffer[2048];
> +    uint8_t  buffer[8192];
>  };
>  
>  struct USBAutoFilter {
> -- 
> 1.6.2.5
> 
>