From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZPkU-0003Rz-P9
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 09:17:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZPkQ-0003PU-5w
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 09:17:02 -0500
Received: from [199.232.76.173] (port=53305 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZPkP-0003PK-QU
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 09:16:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31745)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NZPkO-0005xI-Gh
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 09:16:57 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0PEGpLX013928
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Jan 2010 09:16:51 -0500
Date: Mon, 25 Jan 2010 12:16:43 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/8] Convert migrate_set_speed,
	migrate_set_downtime to QObject
Message-ID: <20100125121643.33dd7748@doriath>
In-Reply-To: <1264425788-8245-1-git-send-email-armbru@redhat.com>
References: <1264425788-8245-1-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 25 Jan 2010 14:23:00 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> These conversions take a few extra steps, because
> do_migrate_set_speed() and do_migrate_set_downtime() interpret their
> string argument as floating-point number + optional unit suffix.  This
> is quite inappropriate for QMP.

 Looks good to me.